search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
39 stars 26 forks source link

Scraper is not using logo and banner from the first playlists channel? #200

Open RavanJAltaie opened 2 months ago

RavanJAltaie commented 2 months ago

Hello, I have an enhancement suggestion that will save time and enhance youtube files quality. Can we update the Youtube scraper in a way that it scrapes the logo of the channel and the banner automatically from the channel ID while scraping the content?

rgaudin commented 2 months ago

It's already the case for channels and playlists have no such thing AFAIK

rgaudin commented 2 months ago

Closing ; reopen if I'm missing anything

RavanJAltaie commented 2 months ago

Can't we apply the same thing on playlists? The playlists are coming from a channel, so adding the channel logo and banner would be very useful.

rgaudin commented 2 months ago

This issue is not actionable. You need to explain what you would like, and why.

You mention saving time so you can only be talking about ZIM Illustration. Those are already fetched by the scraper. It's from the channel/user or the first playlist's channel.

If you are not only talking about ZIM illustration then describe what you get and what you expect.

benoit74 commented 2 months ago

@RavanJAltaie could you explain what you don't get and would like to get with current scraper? Is this just a lack of documentation?

benoit74 commented 2 months ago

@RavanJAltaie should we discuss it live or may I close the issue? We need more details to help you on this

RavanJAltaie commented 1 month ago

@benoit74 @rgaudin the scraper is taking the logo and banner if it's a channel. If it's a playlist, it doesn't. Resulting in a file with no logo and banner, and then we need to enter them manually after checking for files with no logos.

benoit74 commented 1 month ago

I just checked the code, and I confirm that if it's a playlist (or a list of playlist), scraper is supposed to use the logo and banner of the channel of the playlist (or first playlist in the list if we have multiple playlists).

So this is not a feature request, but a bug report.

I checked one random recipe using a playlist as ID (https://farm.openzim.org/recipes/avanti-alkyhalide/config) and the ZIM has both a logo and a banner (https://library.kiwix.org/viewer#avanti-alkyhalide_2024-03/home.html).

image

@RavanJAltaie please provide more information on where this is not working so we can help you debug this issue

benoit74 commented 1 month ago

Nota: the banner is a custom file provided in recipe configuration, I forgot to check that, sorry, but the logo/profile is not specified so it is fetched from online.

benoit74 commented 1 month ago

Clearing milestone until what's needed is clear