search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
38 stars 26 forks source link

Revisit support of Picture-in-Picture #231

Open benoit74 opened 2 weeks ago

benoit74 commented 2 weeks ago

In 2020, https://github.com/openzim/youtube/pull/92 concluded that picture-in-picture button of video.js had to be hidden due to bad support in multiple readers / browsers.

4 years later, it is probably now time to check again if the issues we faced at that time are still present. Picture-in-picture was quite young at that time, it might have evolved significantly since then.

We need to create a small ZIM with only one video served with a video.js player with PIP button enabled. This ZIM does not need to be created with Youtube scraper at all. And then we need to test this ZIM on our readers to confirm if the landscape has changed or not.

kelson42 commented 2 weeks ago

I'm only familiar with PiP in iOS. On iOS, from Kiwix 3.4.0, it already works perfectly using standarts OS workflows/gestures. Therefore, I'm not sure anything else (a button) is needed. But ready to test one if needed.