search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
46 stars 26 forks source link

Write integration tests for the scraper #253

Closed dan-niles closed 2 months ago

dan-niles commented 3 months ago

It would be beneficial if we could write integration tests for the YouTube scraper similar to the one in zimit.

dan-niles commented 2 months ago

@benoit74 I have written a few integration tests in #268. So far, I am checking the existence of channel.json, the video json files, video files, video thumbnails and playlist json files. Do you have any suggestions for any other integration tests that might be useful?

benoit74 commented 2 months ago

Do you have any suggestions for any other integration tests that might be useful?

I would suggest to test for subtitles (there is only one in openZIM test channel, but still good to check it is still there).

Nothing else to suggest, I think this will be a good start and it is always easier to add tests to an existing suite when we discover a bug rather than having to start from scratch. From my PoV job's is sufficient since this goal is reached.