Add support for ogv.js in video player

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist

GNU General Public License v3.0

39 stars 26 forks source link

Add support for ogv.js in video player #259

Closed dan-niles closed 3 days ago

dan-niles commented 5 days ago

In this PR, I added ogv.js as a fallback to video-js for webm playback on unsupported browers. The changes are as follows:

Setup videojs-ogvjs tech plugin in video-js (Custom script taken from here)
Remove openzim.toml since all the dependencies for the UI are now managed using Yarn.
Setup vite-plugin-static-copy to copy ogvjs files from node_modules into the final build/dist folder. (This is needed because the videojs-ogvjs tech plugin needs access to the ogvjs files at runtime)
Add type: "module" back to package.json and rename cypress.config.ts to cypress.config.js.

(Tested webm playback on ogvjs by removing html5 from the TechOrder option in video options.)

Close #230 Close #218

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 1.63%. Comparing base (bcf700e) to head (8f24baa).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #259 +/- ## ======================================== + Coverage 1.61% 1.63% +0.01% ======================================== Files 11 11 Lines 1052 1040 -12 Branches 159 156 -3 ======================================== Hits 17 17 + Misses 1035 1023 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benoit74 commented 3 days ago

Other than this small glitch, very good work!

benoit74 commented 3 days ago

Nota: Firefox issue is in fact also visible with the https://pwa.kiwix.org and with the browser extension ; pwa works well on Chrome and Safari as well

dan-niles commented 3 days ago

Unfortunately I have a bug with kiwix-serve reader on Firefox 127.0.2 on Mac M1 with Sonoma 14.5.

@benoit74 I couldn't reproduce this issue. I tested on Firefox 127.0.2 on Mac M1 with Sonoma 14.5. It is working on kiwix-serve, https://pwa.kiwix.org/ and the Firefox extension for me and I didn't get the above mentioned console warnings.

I did however install a fresh copy of Firefox to do this testing. Can you check if any other extensions in your browser might be causing conflicts?

https://github.com/openzim/youtube/assets/56271899/962c76d8-1984-4a5b-bf30-3bb749506426

benoit74 commented 3 days ago

I confirm that I cannot reproduce the issue on a Browserstack machine. Disabling all extensions does not help. But anyway, for now it really looks to me like a very local problem on my machine. Let's wait for the problem to appear on another machine (hopefully not) to confirm there is a real problem ; I suspect there is no problem. And anyway switching to another browser is also not a very big deal.