Closed dan-niles closed 1 month ago
Attention: Patch coverage is 0%
with 115 lines
in your changes missing coverage. Please review.
Project coverage is 1.58%. Comparing base (
5ae8960
) to head (1815f28
).
Files | Patch % | Lines |
---|---|---|
scraper/src/youtube2zim/scraper.py | 0.00% | 113 Missing :warning: |
scraper/src/youtube2zim/schemas.py | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Nota: just so that it is clear for our future-self, we removed the --no-zim
argument since we are now adding files on-the-fly to the ZIM, so there is no added-value / sense to ask to not create the ZIM.
Oh and btw, we should remove as well the keep_build_dir
/ --keep
as well, build_dir content is not interesting anymore to be kept.
And the documentation about --tmp-dir
argument should be revisited, it is not really accurate anymore.
I recommend to move as much as possible every steps before the long
download_video_files
step. I think thatdownload_authors_branding
,add_main_channel_branding_to_zim
andadd_zimui
are good candidates.
I have moved add_main_channel_branding_to_zim
and add_zimui
to run before the download step in 869b499. However download_authors_branding
cannot be moved since it depends on the get_videos_authors_info
method running before it.
get_videos_authors_info
fetches all the information about the authors of videos and then download_authors_branding
downloads the branding for the fetched authors.
Close #204 Close #209
Changes in this PR:
--no-zim
CLI argument.validate_zimfile_creatable
fromzimscraperlib
to validate if ZIM cannot be created at given location / name.add_files_to_zim
method from Youtube2Zim class, since we no longer have to copy the whole build directory into the ZIM.