Disable preloading of subtitles in video.js

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist

GNU General Public License v3.0

56 stars 30 forks source link

Disable preloading of subtitles in video.js #283

Closed dan-niles closed 4 months ago

dan-niles commented 4 months ago

Close #38

This PR disables the preloading of subtitles in video.js for zimui. Changes include:

Set preloadTextTracks as false for both html5 and ogvjs tech plugins.

Tested on Chrome v127 and Safari 11.1

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 1.54%. Comparing base (402bf37) to head (b5753e0).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #283 +/- ## ===================================== Coverage 1.54% 1.54% ===================================== Files 11 11 Lines 1102 1102 Branches 162 162 ===================================== Hits 17 17 Misses 1085 1085 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dan-niles commented 4 months ago

I made a mistake here. It looks like we don't need to edit the videojs-ogvjs plugin. The plugin already extends the Tech class of video.js which means we can directly use the preloadTextTracks option for ogvjs without any modifications to the plugin.