search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
49 stars 27 forks source link

Fullscreen-exit is broken in firefox/chrome #35

Closed rgaudin closed 4 years ago

rgaudin commented 5 years ago

When exiting fullscreen, if the screen-width is lower than 800px, the video size and position is incorrect.

Might be related to #33

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

kelson42 commented 4 years ago

@rgaudin I don't have a screen with a resolution lower than 800 with Firefox. I have one on Android, but this is a special version of Firefox. Which OS was implied here?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

satyamtg commented 4 years ago

@rgaudin I was not able to replicate this too. I tried with both extensions on Chrome and Firefox and with the Kiwix-serve version. As I don't have a screen with width lower than 800px, I tried to make the screen smaller by resizing with Developer Tools open. All full screen exits seemed to be normal. Could you please elaborate on the device and the OS that you used?

rgaudin commented 4 years ago

Thanks for the updated. I was testing mostly using the developer tools and on a small-end android device that I don't have at hand anymore.

I just tested with http://mirror.download.kiwix.org/zim/other/mali-pour-les-nuls_fr_all_2019-12.zim and couldn't reproduce it.

I suppose we can close it for now. Thanks for the test.