search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
52 stars 29 forks source link

Add `playsinline` to videoJS for proper operation on apple #368

Closed benoit74 closed 3 weeks ago

benoit74 commented 1 month ago

Since we want the video to play inline by default, we have to set the playsinline attribute on video tag.

guptushar27 commented 1 month ago

hi i can debug this

benoit74 commented 1 month ago

There is nothing to debug, just work to do. Do you wanna propose a PR? I've assigned the issue, please propose a PR quickly (by the end of the week at most) or I'll probably work on it, it is just a very tiny change and we would like to release it soon.

guptushar27 commented 1 month ago

I will do this by sunday morning

kelson42 commented 1 month ago

@benoit74 Can we found please a way to ensure that if we have an issue around video.js, it is always fixed everywhare. I'm really surprise to see this bug, as I though it was already fixed everywhere. See https://github.com/openzim/python-scraperlib/issues/194

benoit74 commented 1 month ago

See my last answers in https://github.com/openzim/python-scraperlib/issues/194 ; you keep complaining, we keep explaining it is a problem of tooling / procedures, not something easy to fix. And it will never be fixed everywhere quickly, at least not with our current funding.