search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
52 stars 29 forks source link

Unnecessary duplicate of first video on top of playlist #85

Closed Popolechien closed 4 years ago

Popolechien commented 4 years ago

The first video on the playlist is duplicated and shown on top (both on android and win10)

image

The issue seems to be fairly old, as I see the same issue in a zim from June 2018 and 2019 but not in July 2018

rgaudin commented 4 years ago

It's on purpose. That's been the behavior since forever. I mentioned it when we wrote 2.0. This video in home page is just a preview.

Reclassifying as enhancement. We should hear @kelson42 and @dattaz before changing this.

kelson42 commented 4 years ago

I'm in favour of the suppression of the duplicate as well.

dattaz commented 4 years ago

I don't remember how this video is chosen, but the idea was to has the same behavior as you browse on youtube, for exemple https://www.youtube.com/user/crashcourse you have a "preview" video.

rgaudin commented 4 years ago

It's not chosen, it's just the first video from the playlist.

On youtube, there's one welcome video per-channel. I suppose we replicated the graphical feeling but we don't choose the video because we can't: the welcome video only make sense if you're building a channel and would be independant to the playlist so it would require some UI redo.

I think what we can do at the moment is keep using the first one to get that nice preview UI but remove that video from the list that follows.

satyamtg commented 4 years ago

@kelson42 @Popolechien I agree with @rgaudin that we remove the first video from the video list for now. Have done this and also added a "Read more" to link to the page of the first video in the list. See #86