search

openzim / youtube

Create a ZIM file from a Youtube channel/username/playlist
GNU General Public License v3.0
52 stars 29 forks source link

Fixes #54 - Hide picture-in-picture toggle #92

Closed satyamtg closed 4 years ago

satyamtg commented 4 years ago

Fixes #54 by not displaying PIP toggle if its not supported by the browser. Tested on kiwix-serve versions and Kiwix desktop on Windows and Linux.

@rgaudin could you please confirm if this works on Safari on MacOS?

kelson42 commented 4 years ago

@satyamtg nice!

kelson42 commented 4 years ago

I'm in favour of hidding it eveywhere for the moment because (1) all of this sounds a bit fragile (2) I believe this all should be handled by video.js. But if we do that, I would like to see another ticket to request it's re-introduction if supported by the browser.

rgaudin commented 4 years ago

I'm in favour of hidding it eveywhere for the moment because (1) all of this sounds a bit fragile (2) I believe this all should be handled by video.js. But if we do that, I would like to see another ticket to request it's re-introduction if supported by the browser.

  1. absolutely, that would be very fragile ; that's why I suggested otherwise.
  2. videojs already handles it. It works as expected on native <video /> for chrome and safari and is hidden in firefox where it will never be supported (firefox's choice).

So there would be no point in opening a new ticket to track this in videojs.

satyamtg commented 4 years ago

@rgaudin @kelson42 made the PiP toggle button hidden on the player always. We can now rely on browser feature for Picture in Picture mode.