search

openzim / zim-requests

Want a new ZIM file? Propose ZIM content improvements or fixes? Here you are!
https://farm.openzim.org
37 stars 2 forks source link

English Wikivoyage run overdue (time sensitive) #1129

Closed Jaifroid closed 1 month ago

Jaifroid commented 1 month ago

The periodicity of the ZIM Farm recipe https://farm.openzim.org/recipes/wikivoyage_en_all is set to monthly, but the last run was 16th June 2024.

Ideally, I need a new version for the Wikivoyage by Kiwix app update before the code-signing certificate expires in a couple of weeks... (to buy time in adapting to the new code-signing reigime). Thanks.

kelson42 commented 1 month ago

I will relaunch it with version dev (1.14.0) of MWoffliner, but we will have a ZIM which will be arounf 30% bigger, this is currently a regression we try to fix.

Jaifroid commented 1 month ago

@kelson42 Thank you. Let's see...

Jaifroid commented 1 month ago

The resulting ZIM size is fine at 875MB. However it breaks our Restricted mode (aka JQuery mode) because it has all the sections set with attribute style="display: none;" (see screenshot at bottom). Since we don't run JS in Restricted mode, it means these ZIMs become inaccessible to users who do not have JS enabled in their browser or (in the case of Kiwix JS) cannot run a Service Worker.

This issue has been a longstanding one that was partially fixed: see https://github.com/openzim/mwoffliner/issues/962, https://github.com/openzim/mwoffliner/issues/838, https://github.com/openzim/mwoffliner/issues/952 and (related) https://github.com/openzim/mwoffliner/issues/1033. Another closely related: https://github.com/openzim/mwoffliner/issues/1915.

This regression (but it's worse, see next paragraph) has crept back in probably with the new endpoint. The logic should be: the HTML has all sections open by default, and they should only be closed by a script that will run when JS is enabled. This makes the most accessible ZIM type for mwOffliner.

The regression is much worse now because each whole section containing a details-summary block is now hidden, instead of the block itself being closed. It should never use inline display: none; rule, and should rely only on the open attribute only for the details-summary section.

@kelson42, @audiodude Where should I report this regression? In mwOffliner Repo or wp1?

image

I can work around this in the reader for the upcoming Wikivoyage release with a temporary patch to force-unhide, but it should be fixed in the scraper for a more universal solution.

kelson42 commented 1 month ago

@Jaifroid We won't provide collapsablible sections anymore as this was a feature of older "mobile-section" API. This seems therefore some kind of leftover which shoukd be removed IMHO. Please open tocket in MWoffliner.

Jaifroid commented 1 month ago

@kelson42 OK. I suppose https://github.com/openzim/mwoffliner/issues/1915 should be closed as won't fix in that case. I mean, it's not hard to substitute the sections and headers for detail-summary tags in case there's any desire to keep that feature, but to be honest I never found it useful to have all the sections closed, even in the mobile version.