NHS Medicines A to Z - Githubissues

openzim / zim-requests

Want a new ZIM file? Propose ZIM content improvements or fixes? Here you are!

https://farm.openzim.org

37 stars 2 forks source link

NHS Medicines A to Z #1138

Open Popolechien opened 4 weeks ago

Popolechien commented 4 weeks ago

Website URL: https://www.nhs.uk/medicines
License: OGL (Open Government license)
Desired ZIM Title: NHS' Medicines A to Z
Desired ZIM Description: How medicines work, how and when to take them, side effects and common questions
Desired ZIM Icon –png (URL or attach one): https://www.nhs.uk/static/nhsuk/img/favicons/favicon-192x192.43924bfe6c7e.png
Language (ISO 639-3): eng
Is this a MediaWiki?: no

Pretty much a copy of #323

RavanJAltaie commented 3 weeks ago

Recipe created https://farm.openzim.org/recipes/nhs.uk-medicines_en_all I'll update the library once ready

RavanJAltaie commented 2 weeks ago

File is ready at the library https://library.kiwix.org/viewer#nhs.uk-medicines_en_all_2024-08

kelson42 commented 2 weeks ago

Not ready, all top bar links are directly pointing to the online Web site.

Can we do something about this recurring cookie banner?

Popolechien commented 2 weeks ago

@kelson42 That's because we only scraped a subset of the top-level site I believe. Either way, I suspect this fits what I described at https://github.com/openzim/zimit/issues/374

RavanJAltaie commented 2 weeks ago

@kelson42 we are scrapping only the medicine part, not all the website. The tabs are for other fields.

benoit74 commented 1 week ago

Any reason to not hide the top bar then, if it only contains links to non-working parts, I see little reason to keep it?

Only concern it that we have no more button/link to "home" if we remove the top links, but most readers have one, isn't it?

And since we also scrape the "conditions" part in a different ZIM, do we really need to have two distinct ZIMs ? The medicine part seems to be only few 10s of MB, not something very concerning to justify being put aside, or do I miss something?

Popolechien commented 1 week ago

While it may make sense for the NHS website to have both conditions and medicines on a single website, I would argue that the way we present content makes it more approchable if it is one zim = one type of content.

Agree on removing the top bar, though we would lose the NHS branding and that is a bit of a bummer; but I see two home buttons (which don't work as they point to nhs.uk) - the NHS logo and the Home hyperlink. Screenshot 2024-09-02 at 10 01 54

benoit74 commented 1 week ago

OK then let's go for two ZIMS (but ZIM names will have to be fixed, see https://github.com/openzim/zim-requests/issues/1153).

Not sure it is feasible, but what you should request me to do (from my own PoV, I'm clearly a silly person ^^) is to remove following zones in red:

Screenshot 2024-09-02 at 11 52 40