search

openzim / zim-requests

Want a new ZIM file? Propose ZIM content improvements or fixes? Here you are!
https://farm.openzim.org
42 stars 3 forks source link

New request: benyehuda.org #1187

Open benoit74 opened 1 month ago

benoit74 commented 1 month ago

I'm not the original requester, but we have this recipe in the farm, so I'm opening this issue to discuss what's next.

benoit74 commented 1 month ago

Recipe is at https://farm.openzim.org/recipes/benyehuda.org_he_all

We have a ZIM ready for review in dev: https://dev.library.kiwix.org/#lang=&q=%D7%A4%D7%A8%D7%95%D7%99%D7%A7%D7%98

The ZIM seems to be quite complete, however a lot of search screens (see e.g. https://dev.library.kiwix.org/viewer#benyehuda.org_he_all_2024-10/benyehuda.org/authors, you cannot click on any letter) are not working, and they are probably never going to work with zimit.

It is hard to hide these broken screens because it mostly means removing all the navigation buttons in the top bar of the screen.

But it is also hard to not publish a ZIM whose content is probably complete, is searchable (via the reader / ZIM indexes), navigation works mostly ok but few important search screens are broken.

WDYT?

benoit74 commented 1 month ago

Edit: updated previous comment with sample URL where search is broken

Popolechien commented 1 month ago

Quite a few of the (internal) links on the left hand-side bar do not work / are considered external links and thus blocked (structure is benyehuda.org/read/number

I'm not 100% sure but I suspect this website has been created / saw involvement by one of the WMF trustees. Should I ask her to check whether the broken navigation still is useful?

benoit74 commented 1 month ago

Quite a few of the (internal) links on the left hand-side bar do not work / are considered external links and thus blocked (structure is benyehuda.org/read/number

I failed to find them at first sight, looks like mostly only first two authors are impacted ... This should probably be fixed indeed. I don't know why they are not in the ZIM, this is not normal