openzim / zim-requests

Want a new ZIM file? Propose ZIM content improvements or fixes? Here you are!
https://farm.openzim.org
41 stars 3 forks source link

New Request: cloudflare.com/learning/ #530

Open Rexadev opened 1 year ago

Rexadev commented 1 year ago
RavanJAltaie commented 1 year ago

Recipe is created, labeled for review, will update here once succeeded or failed https://farm.openzim.org/recipes/cloudflare_en_all

RavanJAltaie commented 1 year ago

@Rexadev The file has been created but no functioning properly. I'm investigating it

RavanJAltaie commented 1 year ago

Recipe failed.

RavanJAltaie commented 1 year ago

The recipe succeeded earlier but the output file is not complete.

Popolechien commented 1 year ago

@Rexadev Because the recipe has been created. The dependency is on zimit now where the bug is. We will re-run it when the tool is updated but there is nothing else we can do for the time being.

Rexadev commented 8 months ago

@Popolechien Recipe succeeded once please upload that to library

Rexadev commented 6 months ago

@RavanJAltaie Updates

benoit74 commented 4 months ago

I fixed the recipe (moved URL from https://www.cloudflare.com/learning to https://www.cloudflare.com/learning/ so that prefix scope works correctly and we do not scrape the whole Cloudflare website), migrated it to Zimit 2.0.1 and relaunched the recipe.

Hopefully it will do the job. A custom CSS would help to hide everything which is not going to be offlined.

benoit74 commented 4 months ago

I also fixed the recipe name and ZIM name (from cloudflare_en_learning to cloudflare.com_en_learning-center). Recipe is now at https://farm.openzim.org/recipes/cloudflare.com_en_learning-center.

benoit74 commented 4 months ago

@RavanJAltaie could you please have a look, the ZIM seems pretty ok to me: https://dev.library.kiwix.org/viewer#cloudflare.com_en_learning-center_2024-06. I recommend to hide some stuff with custom CSS, but other than that it seems the ZIM is pretty good.

RavanJAltaie commented 4 months ago

@benoit74 all links and categories inside resources button are either don't open or leads to a (not found) page.

image
benoit74 commented 4 months ago

@RavanJAltaie all these links are not part of the cloudflare learning center, so they are excluded on purpose since this request is about the learning center. Do you still want to ZIM them? I think this header and the footer of the page should be hidden since they contains mostly only broken links not related to the learning center.

RavanJAltaie commented 4 months ago

@benoit74 I don't want to ZIM them but let's hide them because anyone who will use the file will click on them and will think they are a part of the file which don't open or work.

benoit74 commented 4 months ago

Custom CSS has been written and recipe reconfigured and requested.

Developing the custom CSS I realized that learning center content is in fact available in many more languages: Screenshot 2024-07-01 at 09 10 30

These other languages are not in current ZIM (which is hence correct) but I think we should duplicate the recipe to have on ZIM per language available to increase availability of this content. @RavanJAltaie can you do that please?

benoit74 commented 4 months ago

custom CSS was insufficient, not coverage all banners Cloudflare tries to add, so I fixed this and restarted the recipe

RavanJAltaie commented 4 months ago

Custom CSS has been written and recipe reconfigured and requested.

Developing the custom CSS I realized that learning center content is in fact available in many more languages: Screenshot 2024-07-01 at 09 10 30

These other languages are not in current ZIM (which is hence correct) but I think we should duplicate the recipe to have on ZIM per language available to increase availability of this content. @RavanJAltaie can you do that please?

I can do that, are we expecting a zim file for each of the available languages? @benoit74 @Popolechien

Popolechien commented 4 months ago

are we expecting a zim file for each of the available languages?

Ideally yes, as I have developed a strong disliked of all things multilingual.

benoit74 commented 4 months ago

Agreed regarding the one recipe / one ZIM per available language, there is no reason / interest / constraint in creating a mul ZIM here.

Regarding en, I let you check https://dev.library.kiwix.org/viewer#cloudflare.com_en_learning-center_2024-07, I think you can now move the recipe to production, I let you decide / do this

benoit74 commented 4 months ago

PS: I think we need only one ZIM per language, i.e. we do not mind about the English and Espanol locales (UK, Canada, ...), we just ZIM the most "popular" locale.

RavanJAltaie commented 4 months ago

@benoit74 Noted.