openzim / zim-requests

Want a new ZIM file? Propose ZIM content improvements or fixes? Here you are!
https://farm.openzim.org
42 stars 3 forks source link

ChopinEarlyEditionsCollection by UniversityOfChicagoLibrary chopin.lib.uchicago.edu #604

Open Rexadev opened 1 year ago

Rexadev commented 1 year ago

Please use the following format for a ZIM creation request (and delete unnecessary information)

RavanJAltaie commented 7 months ago

Recipe created https://farm.openzim.org/recipes/chopin.lib.uchicago.edu_en_all I'll update the library link once ready

RavanJAltaie commented 7 months ago

Files Succeeded https://dev.library.kiwix.org/viewer#chopin.lib.uchicago.edu_en_all_2024-04 but one link was not working because it re-directs to another website https://www.lib.uchicago.edu/scrc/ I've added this URL to (Include) Parameter, @benoit74 is that correct?

Rexadev commented 7 months ago

https://www.lib.uchicago.edu/scrc/ also has other things @RavanJAltaie

benoit74 commented 7 months ago

As @Rexadev said/confirm, we do not want to include the content of https://www.lib.uchicago.edu/scrc/ inside the ZIM, so adding them in the include list does not help at all.

These links which are broken should in fact lead to the online resource, so that when users are online they will be able to browse this link and when they are offline they will be presented with the regular browser saying something like "sorry we cannot access this page".

The fact that it is not displaying this message is a known zimit1 issue. I suggest to tag this as "upstream" and wait for zimit2 to solve the issue.

RavanJAltaie commented 7 months ago

@benoit74 I've removed the link from the include parameter. Tagged the issue as upstream.

benoit74 commented 1 month ago

zimit2 achieved to create a pretty cool ZIM.

However there is at least two problems left to fix.

First if you go to https://dev.library.kiwix.org/viewer#chopin.lib.uchicago.edu_en_all_2024-09/chopin.lib.uchicago.edu/gsdl/cgi-bin/library%3Fe%3Dd-000-00---0chopin--00-0-0-0prompt-10---4---Document---0-1l--1-en-Zz-1---50-home---001-001-1-0utfZz-8-0%26a%3Dd%26cl%3DCL1.1%26d%3DCHOP124.1 and select another page in the combobox, it is not working ; navigating with prev/next works as expected ; this is an upstream bug, I will open an issue.

Image

Second the high res images have not been fetched while they are mostly essential ; we need to update the recipe configuration to also include http://www.lib.uchicago.edu/chopin/images/*.

Image

@Popolechien given the upstream bug will probably take time to fix and the combobox is not essential, we already have the next / prev links, shall we simply hide the combobox with CSS so that we can publish the ZIM? @Rexadev do you think the ZIM will still be usable without this combox box

benoit74 commented 1 month ago

Upstream issue is at https://github.com/openzim/warc2zim/issues/409

Popolechien commented 1 month ago

LGTM

benoit74 commented 1 month ago

I just fixed the CSS (I also hide search page which is not working / needed) and requested again in dev.