openzim / zim-requests

Want a new ZIM file? Propose ZIM content improvements or fixes? Here you are!
https://farm.openzim.org
37 stars 2 forks source link

Wikimed AR and JA are not clickable #777

Open Popolechien opened 8 months ago

Popolechien commented 8 months ago

Looking at Wikimed JA and AR, on both apps' front page none of the links appear clickable.

Links elsewhere in the zim seem to work fine (see, e .g., those here)

This is a major blocker for ../../kiwix/kiwix-android-custom/issues/161

kelson42 commented 8 months ago

@Popolechien These links are not clickable because the target articles are not available. Actually the links should be removed, there is a weakness in MWoffliner here. But at the core of the problem is this kind of modification! MWoffliner has no clue of these new pages.

Special Wikimed pages are hardocoded at https://github.com/openzim/wp1_selection_tools/blob/main/build_custom_selections.sh#L71. And then they should be properly linked via interwiki links.

@RavanJAltaie @Popolechien Can you please secure this is OK for all languages with James?

Popolechien commented 8 months ago

Ok we may have a bigger problem here as looking at https://github.com/openzim/wp1_selection_tools/blob/main/build_custom_selections.sh#L71 none of the books seem to exist anymore (see, e.g., Wikipedia:Books/archive/Cardiology).

Popolechien commented 8 months ago

Ah I see the Books extension was deprecated in 2021.

Guess the selection tool would benefit from a bit of freshening up.

WikiDocJames commented 7 months ago

Yup the book extension was deleted across most / all versions of WP. So basically in Japanese we moved to using userspace pages. Let me know if anything needs to be done on WP to fix things are if this can be taken care of on your end.

kelson42 commented 7 months ago

@WikiDocJames I think everything is in my comment:

WikiDocJames commented 7 months ago

Okay so to clarify you are using the EN WP version as a template and then following the interlanguage links via Wikidata to find the corresponding versions in other languages? The problem is that Wikidata will not allow linking to a userspace. I could try moving to Wikipedia space on JA, but not sure it will survive their... Okay done for Japanese. Will look at Arabic in a bit.

WikiDocJames commented 7 months ago

Looking at Arabic and not sure what the issue is... As it appears to be linked https://www.wikidata.org/wiki/Q115765957#sitelinks-wikipedia

RavanJAltaie commented 7 months ago

I found the problem. Both Fixed, Arabic & Japanese. @Popolechien Please double check so I can close the issue

kelson42 commented 5 months ago

@RavanJAltaie AFAIK this is not fixed, please if you fixed something please explain what, at least by providing a link.

Going to fix https://github.com/openzim/wp1_selection_tools/issues/47 first and see if there is somewhere a problem there or somewhere else.

RavanJAltaie commented 5 months ago

The problem was that the link of the landing page was changed and I've updated the recipe, the recipe succeeded but I checked it and the links are still not clickable as follows

image

This is the file https://library.kiwix.org/viewer#wikipedia_ar_medicine_maxi_2024-03 @benoit74 any idea?

benoit74 commented 5 months ago

This is probably more a question for @kelson42, he is assigned on the ticket, has already advised on what needed to be done and has far more experience on this topic than I do. Did you understood what was supposed to be done to have this working? If yes, did you checked this has been done? If not, did you asked for more explanation by @kelson42? You need to have an understanding of this kind of issue so that you can diagnose a little bit what is going on. Don't be afraid to ask questions if things are unclear.

WikiDocJames commented 5 months ago

I have no idea. I see this is the main page https://ar.wikipedia.org/wiki/%D9%88%D9%8A%D9%83%D9%8A%D8%A8%D9%8A%D8%AF%D9%8A%D8%A7:%D9%85%D8%B4%D8%B1%D9%88%D8%B9_%D9%88%D9%8A%D9%83%D9%8A_%D8%B7%D8%A8/%D9%85%D8%B1%D8%AC%D8%B9_%D8%A8%D8%AF%D8%A7%D9%8A%D8%A9_%D8%A7%D9%84%D8%AA%D8%B7%D8%A8%D9%8A%D9%82_%D8%A7%D9%84%D8%B7%D8%A8%D9%8A2

And the links there work. The links are connected via wikidata.

RavanJAltaie commented 4 months ago

If you search through the library you'll get 3 files for the 3 flavours, maxi, mini, and nopic I opened three of them and the links inside the file are not clickable

image

The landing page itself is working fine, and it's assigned properly inside the recipe (Landing page) I couldn't figure out what's the problem? @kelson42 @Popolechien

Popolechien commented 4 months ago

I couldn't get to the Japanese landing page at https://library.kiwix.org/viewer#wikipedia_ja_medicine_maxi - I've restarted the recipe