search

openzim / zim-tools

Various ZIM command line tools
https://download.openzim.org/release/zim-tools/
GNU General Public License v3.0
133 stars 35 forks source link

Windows release archive doesn't have `zimwriterfs` #354

Open shenlebantongying opened 1 year ago

shenlebantongying commented 1 year ago

Download https://download.openzim.org/release/zim-tools/zim-tools_win-i686-3.2.0-1.zip

There is no zimwriterfs.exe

kelson42 commented 1 year ago

@mgautierfr Should I move the ticket to kiwix/kiwix-build?

rgaudin commented 1 year ago

See https://github.com/kiwix/kiwix-build/blob/10e920ca00819ee837bf5d293a23585399b3b2a4/kiwixbuild/dependencies/zim_tools.py#L25

mgautierfr commented 1 year ago

zimwriterfs has been introduced in zim-tools with https://github.com/openzim/zim-tools/pull/104 From the comments, it seems totally natural we don't build on Windows but we never say why. I simply suspect that zimwriterfs is not totally ported on Windows.

kelson42 commented 2 months ago

@mgautierfr An update would be welcome here

mgautierfr commented 2 months ago

zimwriterfs need libmagic to detect the mimetype of the added file and we currently cannot compile it on Windows.

kelson42 commented 2 months ago

@mgautierfr Issue link? Filemagic should not be 100% indispensible AFAIK as we have anyway an extension based mime-type mapping table. This is good enough for 99% of the use case. This would be an acceptable workaround.

mgautierfr commented 2 months ago

There is this meta-issue : https://github.com/kiwix/kiwix-build/issues/729

kelson42 commented 2 months ago

At this stage, gumbo and libmagic are not available easily for compilation on Windows. For sure this is the case of libmagic. For this reason we still struggle to have zimwriterfs in the Windows release.