openzim / zim-tools

Various ZIM command line tools
https://download.openzim.org/release/zim-tools/
GNU General Public License v3.0
123 stars 34 forks source link

Adjust to number of captures in previous regex #360

Closed mgautierfr closed 1 year ago

mgautierfr commented 1 year ago

supersedes #359

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 28.57% and project coverage change: +0.17% :tada:

Comparison is base (82109ba) 27.52% compared to head (e4dc68e) 27.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #360 +/- ## ========================================== + Coverage 27.52% 27.70% +0.17% ========================================== Files 26 26 Lines 2521 2527 +6 Branches 1346 1349 +3 ========================================== + Hits 694 700 +6 + Misses 1356 1346 -10 - Partials 471 481 +10 ``` | [Files Changed](https://app.codecov.io/gh/openzim/zim-tools/pull/360?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim) | Coverage Δ | | |---|---|---| | [src/zimwriterfs/zimcreatorfs.h](https://app.codecov.io/gh/openzim/zim-tools/pull/360?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim#diff-c3JjL3ppbXdyaXRlcmZzL3ppbWNyZWF0b3Jmcy5o) | `16.66% <ø> (ø)` | | | [src/zimwriterfs/zimcreatorfs.cpp](https://app.codecov.io/gh/openzim/zim-tools/pull/360?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim#diff-c3JjL3ppbXdyaXRlcmZzL3ppbWNyZWF0b3Jmcy5jcHA=) | `22.77% <28.57%> (+2.36%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgautierfr commented 1 year ago

@veloman-yunkan comment fixed. Packages CI failing is not related to this change.

I'm merging.