search

openzim / zim-tools

Various ZIM command line tools
https://download.openzim.org/release/zim-tools/
GNU General Public License v3.0
133 stars 35 forks source link

Fix zimwriterfs and missing magic file. #374

Closed mgautierfr closed 1 year ago

mgautierfr commented 1 year ago

Fix #371

codecov[bot] commented 1 year ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (e4440d1) 27.72% compared to head (109afe5) 27.58%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #374 +/- ## ========================================== - Coverage 27.72% 27.58% -0.15% ========================================== Files 26 26 Lines 2528 2541 +13 Branches 1349 1350 +1 ========================================== Hits 701 701 - Misses 1346 1359 +13 Partials 481 481 ``` | [Files](https://app.codecov.io/gh/openzim/zim-tools/pull/374?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim) | Coverage Δ | | |---|---|---| | [src/zimwriterfs/zimwriterfs.cpp](https://app.codecov.io/gh/openzim/zim-tools/pull/374?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openzim#diff-c3JjL3ppbXdyaXRlcmZzL3ppbXdyaXRlcmZzLmNwcA==) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgautierfr commented 1 year ago

Yes. But for me it should not be in. I suspect a too "large" try block. The try/catch is to catch error from the zim creation. parse_args has no reason to throw a exception.