search

openzim / zim-tools

Various ZIM command line tools
https://download.openzim.org/release/zim-tools/
GNU General Public License v3.0
123 stars 34 forks source link

Mark the redirect articles coming from redirect file as front articles. #387

Closed mgautierfr closed 10 months ago

mgautierfr commented 10 months ago

This way, they are correctly title indexed.

Fixes #388

mgautierfr commented 10 months ago

Test are missing. But there is not existing test creating archive with a redirect file as input. We can add it, but it will a bit longer than this quick fix.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8d143f4) 28.06% compared to head (8c3bff7) 28.00%.

Files Patch % Lines
src/zimwriterfs/zimcreatorfs.cpp 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #387 +/- ## ========================================== - Coverage 28.06% 28.00% -0.07% ========================================== Files 26 26 Lines 2576 2582 +6 Branches 1371 1373 +2 ========================================== Hits 723 723 - Misses 1369 1375 +6 Partials 484 484 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgautierfr commented 10 months ago

Agree with @kelson42 to merge as it is.