search

openzim / zim-tools

Various ZIM command line tools
https://download.openzim.org/release/zim-tools/
GNU General Public License v3.0
123 stars 34 forks source link

[CHECK] Do not continue with other checks if integrity check fails. #413

Closed mgautierfr closed 3 months ago

mgautierfr commented 3 months ago

It make no sense to check content in a zim archive if the zim archive itself is broken and we can't read it.

Fix openzim/libzim#893

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 11.53846% with 23 lines in your changes missing coverage. Please review.

Project coverage is 27.02%. Comparing base (d6c6a1b) to head (875e09a).

Files Patch % Lines
src/zimcheck/zimcheck.cpp 4.16% 0 Missing and 23 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #413 +/- ## ========================================== + Coverage 26.98% 27.02% +0.03% ========================================== Files 26 26 Lines 2453 2457 +4 Branches 1338 1340 +2 ========================================== + Hits 662 664 +2 Misses 1304 1304 - Partials 487 489 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgautierfr commented 3 months ago

Fixed. Directly merge if you agree.