openzim / zimfarm

Farm operated by bots to grow and harvest new zim files
https://farm.openzim.org
GNU General Public License v3.0
81 stars 25 forks source link

Zim files created in dev should default to manual refresh #1009

Open Popolechien opened 1 month ago

Popolechien commented 1 month ago

The typical manner to create a new recipe is to copy an exisiting one, change the parameters and assign it to dev. It happens quite often that one forgets to change the update settings and leave it to monthly, meaning that if the recipe is not successful and not moved to PROD it may keep on generating new zim files every month, potentially clogging the dev repo (by "not successful" I understand that a zim is produced, but does not meet quality requirements and thus could be considered junk).

Now the typical fix for that would be to say "check your parameters", but I think having a harder check, i.e. the periodicityparameter automatically change to manual as soon as the warehouse path is set to /.hidden/dev would be much more efficient.

benoit74 commented 1 month ago

I agree that something needs to be done, but I'm not sure the solution proposed is adequate.

If one forgets to set the periodicity to manual when in dev and the software is modified to do this change automatically, then I'm pretty sure that the periodicity will stay to manual once move to prod, so we will only have moved the problem.

Sorry that this comment does not propose an alternative.

benoit74 commented 1 month ago

Maybe implementing warnings in the UI would help:

I can see many other use cases for such warnings.