openzim / zimit-frontend

Zimit Public Web UI
https://zimit.kiwix.org
GNU General Public License v3.0
7 stars 8 forks source link

Reject requests for Wikipedia zim files. #25

Closed Popolechien closed 2 years ago

Popolechien commented 3 years ago

I see a number of duplicate requests from users, but also request to zim files we generate elsewhere (ie, wikipedia_en). Zimit should check against the list of available zim files and redirect them to the user. In the case of zimit-generated files who have an expiry day, considering their relative small size it redirection could still happen if said files are less than 4-5 days old.

rgaudin commented 3 years ago

Hum, there are two distinct issues here. This might get stale.

As for the first one, since we don't record the Source of a website inside ZIMs/library, we can't check automatically. A simpler approach would be to simply reject Wikipedia or youtube or TED requests and display a special page informing about the other scraper that are most appropriate and how they should use zim-requests.

For the second one, I'm not sure. How many exactly similar requests from different people do we get within 7d periods? Is it worth it? Or maybe it's identical or very similar requests from the same person, fixing mistakes as we have no cancel mechanism.

Popolechien commented 3 years ago

Yeah I considered opening two tickets. Will do.

For this one then let's focus on rejecting Wikipedia zim files. A simple page saying "Wikipedia is already available on Kiwix! Check the in-app library. +back to zimit" (though in that case I don't know what we should say to people on macOS and kiwix-JS who have no in-app library to turn to. Send everyone back to library.kiwix.org once it's revamped?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

rgaudin commented 2 years ago

Closing in favor of #28