openzim / zimit-frontend

Zimit Public Web UI
https://zimit.kiwix.org
GNU General Public License v3.0
9 stars 8 forks source link

Limit download size for user-input URLs #67

Open rgaudin opened 1 month ago

rgaudin commented 1 month ago

With illustration already and behaviors soon (maybe?), our worker can be ordered to download arbitrary URLs without stopping at any specific size. That's a potential hazard.

We should check how the crawler enforces the limit we use as well ; it could be a simple post-write check which might be vulnerable as well.

benoit74 commented 1 month ago

Agreed, this is a "significant" security concern. Probably something to solve in scraper (or scraperlib even).