search

openzim / zimit

Make a ZIM file from any Web site and surf offline!
GNU General Public License v3.0
359 stars 25 forks source link

Add a `--version` command #234

Closed benoit74 closed 7 months ago

benoit74 commented 1 year ago

Allow to display zimit version with zimit --version ; this should also display version of warc2zim and browsertrix crawler.

kelson42 commented 1 year ago

Sounds mandatory. Not sure if this is already made, but at starts of scrape, clearly writing in the log the version of the scraper is often pretty usefuly as well. Considering that for Zimit, we use intensively the dev version, writting the version of the dependences at start as well would probably be helpful.

Syoinn commented 7 months ago

Hello! I'm trying to work on this function. But I need advice on a couple of points:

  1. Should I add environment variables to the Dockerfile or hardcode the versions in zimit.py? Am I on the right track?
  2. You mentioned the log, but I’m not sure what it actually points to. Does it mean the log generated by browsertrix-crawler, or just let zimit print a version number when running?

I am a newcomer, and I wanna make sure I understand the issue correctly. Your advice would be very helpful.

benoit74 commented 7 months ago

@Syoinn sorry, this has already been solved by https://github.com/openzim/zimit/pull/272, we've forgot to mention it over there and close this issue