openzim / zimit

Make a ZIM file from any Web site and surf offline!
GNU General Public License v3.0
335 stars 24 forks source link

Invalid leading whitespace in User-Agent header #281

Closed benoit74 closed 3 months ago

benoit74 commented 7 months ago

See https://farm.youzim.it/pipeline/588ad4d1-0f4a-4705-8cc6-183d97800cab/debug

Error is:

failed to connect to https://mr3.pw/female-escorts-in-colombo: Invalid leading whitespace, reserved character(s), or returncharacter(s) in header value: ' Youzim.it+ contact+zimfarm@kiwix.org'

(i.e. this is a Python error, probably in check_url)

benoit74 commented 7 months ago

The problem is that the user passed a blank userAgent (and blank creator and blank description):

zimit --creator= --userAgent= --description= --url=https://mr3.pw/female-escorts-in-colombo --name=mr3.pw_633ac3f0 --zim-file=mr3.pw_633ac3f0.zim --userAgentSuffix=Youzim.it+ --sizeLimit=4294967296 --timeLimit=7200 --output=/output --statsFilename=/output/task_progress.json --adminEmail=contact+zimfarm@kiwix.org --publisher=openZIM