search

openzim / zimit

Make a ZIM file from any Web site and surf offline!
GNU General Public License v3.0
335 stars 24 forks source link

URL is different in error message #282

Closed rgaudin closed 7 months ago

rgaudin commented 7 months ago

In this run on zimit, the error message is the following:

failed to connect to https://americangirl.fandom.com/wiki: 404 Client Error: Not Found for url: https://americangirl.fandom.com/wiki/Wiki

Notice that the passed URL has a title cases Wiki at the end while the error message has a lowercase wiki.

Source code apparently only uses urllib.parse.urlparse(url).geturl() which should return the same URL in this case

benoit74 commented 7 months ago

The first one is https://americangirl.fandom.com/wiki (it is the URL passed by the "user") The next one is https://americangirl.fandom.com/wiki/Wiki (it is the URL after following redirects, probably what requests choose to display here)

I don't think there is any problem here

rgaudin commented 7 months ago

My bad, I thought it was the opposite 😵‍💫