Incompatibility with nodejs10

[kelson42]

$ docker run -p 8000:8000 phets | more
0|index    | node /app/build/index.js[20]: ../src/node_contextify.cc:628:static void node::contextify::ContextifyScript::New(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[1]->IsString()' fa
iled.
0|index    |  1: 0x8dbaa0 node::Abort() [node /app/build/index.js]
0|index    |  2: 0x8dbb75  [node /app/build/index.js]
0|index    |  3: 0x90f2f7 node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [node /app/build/index.js]
0|index    |  4: 0xb5f72b  [node /app/build/index.js]
0|index    |  5: 0xb616c2 v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [node /app/build/index.js]
0|index    |  6: 0x39086535be1d 
PM2        | App [index] with id [0] and pid [20], exited with code [0] via signal [SIGABRT]
PM2        | Starting execution sequence in -fork mode- for app name:index id:0
PM2        | App name:index id:0 online
0|index    | node /app/build/index.js[51]: ../src/node_contextify.cc:628:static void node::contextify::ContextifyScript::New(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[1]->IsString()' fa
iled.
0|index    |  1: 0x8dbaa0 node::Abort() [node /app/build/index.js]
0|index    |  2: 0x8dbb75  [node /app/build/index.js]
0|index    |  3: 0x90f2f7 node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [node /app/build/index.js]
0|index    |  4: 0xb5f72b  [node /app/build/index.js]
0|index    |  5: 0xb616c2 v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [node /app/build/index.js]
0|index    |  6: 0x27547bc5be1d 
PM2        | App [index] with id [0] and pid [51], exited with code [0] via signal [SIGABRT]
PM2        | Starting execution sequence in -fork mode- for app name:index id:0
PM2        | App name:index id:0 online
0|index    | node /app/build/index.js[78]: ../src/node_contextify.cc:628:static void node::contextify::ContextifyScript::New(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[1]->IsString()' fa
iled.
0|index    |  1: 0x8dbaa0 node::Abort() [node /app/build/index.js]
0|index    |  2: 0x8dbb75  [node /app/build/index.js]
0|index    |  3: 0x90f2f7 node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [node /app/build/index.js]
0|index    |  4: 0xb5f72b  [node /app/build/index.js]
0|index    |  5: 0xb616c2 v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [node /app/build/index.js]
0|index    |  6: 0x2853c0b5be1d 
PM2        | App [index] with id [0] and pid [78], exited with code [0] via signal [SIGABRT]
PM2        | Starting execution sequence in -fork mode- for app name:index id:0
PM2        | App name:index id:0 online
0|index    | node /app/build/index.js[105]: ../src/node_contextify.cc:628:static void node::contextify::ContextifyScript::New(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[1]->IsString()' f
ailed.
0|index    |  1: 0x8dbaa0 node::Abort() [node /app/build/index.js]
0|index    |  2: 0x8dbb75  [node /app/build/index.js]
0|index    |  3: 0x90f2f7 node::contextify::ContextifyScript::New(v8::FunctionCallbackInfo<v8::Value> const&) [node /app/build/index.js]
0|index    |  4: 0xb5f72b  [node /app/build/index.js]
0|index    |  5: 0xb616c2 v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [node /app/build/index.js]
0|index    |  6: 0x210f6f9dbe1d 
PM2        | App [index] with id [0] and pid [105], exited with code [0] via signal [SIGABRT]
PM2        | Starting execution sequence in -fork mode- for app name:index id:0
PM2        | App name:index id:0 online

[ISNIT0]

Seems to work for me on 10. We'll see if #15 fixes things

[kelson42]

@ISNIT0 Maybe a problem with Docker, just try to install nodejs10 in Dockerfile and then you should get the same errors... I guess.

[ISNIT0]

Yes, see this: https://github.com/openzim/zip2zim/issues/24