search

openzipkin-attic / apache-release-verification

Apache License 2.0
3 stars 1 forks source link

Support checking projects which do not have "module name" in their github path #13

Closed devinsba closed 5 years ago

devinsba commented 5 years ago

When we migrate the zipkin project into the Apache repo, it will be located at: https://github.com/apache/incubator-zipkin.git, the code as it exists now would look for it at: https://github.com/apache/incubator-zipkin-zipkin.git

devinsba commented 5 years ago

To a lesser extent this affects our ability to check projects outside of zipkin also, ones that do not have modules at all, where their git repo will be hosted like the zipkin one, and their release path will be https://dist.apache.org/repos/dist/dev/incubator/${projectName}/${version}/ instead of https://dist.apache.org/repos/dist/dev/incubator/${projectName}/${moduleName}/${version}/

abesto commented 5 years ago

Nice one. My first idea for approaching this is making --module optional, and dropping that part of the URL path if not provided.