search

openzipkin-attic / apache-release-verification

Apache License 2.0
3 stars 1 forks source link

Add --github-reponame-template, generalize optional placeholders #17

Closed abesto closed 5 years ago

abesto commented 5 years ago

Watch out, this is on top of #16, you probably only want to look at the last commit if reviewing before that's merged.

This allows verifying Apache Zipkin Layout Factory 0.0.5 currently up for vote as follows:

python src/main.py --project zipkin --module zipkin-layout-factory \
    --version 0.0.5 --gpg-key 50D90C2C \
    --git-hash 23dbddb426b4113c4b8633808b9ff0df3454e201 --repo dev \
    --zipname-template 'apache-{module}{dash_incubating}-{version}-source-release' \
    --github-reponame-template '{incubator_dash}{module}.git'
abesto commented 5 years ago

PS. Depending on the outcome of the discussion around naming the SVN path, this might be the trigger for shipping some template presets. I'm thinking it'd be nice if the script could figure out on its own which templates to use for a project. We have a bootstrapping problem fetching the repo though, which means it'd need to be "out of band", so either shipped with the script, or fetched from a known location managed separately from the script. Or otherwise it could "just" brute-force its way through all template presets, though that feels dirty and hacky and moderately confusion-inducing.

codefromthecrypt commented 5 years ago

one way would be to remove zipkin- unless that results in empty string

On Fri, Apr 26, 2019 at 5:06 PM Zoltán Nagy notifications@github.com wrote:

PS. Depending on the outcome of the discussion around naming the SVN path, this might be the trigger for shipping some template presets. I'm thinking it'd be nice if the script could figure out on its own which templates to use for a project. We have a bootstrapping problem fetching the repo though, which means it'd need to be "out of band", so either shipped with the script, or fetched from a known location managed separately from the script. Or otherwise it could "just" brute-force its way through all template presets, though that feels dirty and hacky and moderately confusion-inducing.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/openzipkin-contrib/apache-release-verification/pull/17#issuecomment-486967741, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAPVVYDWIZSQZ6N3BH2RCDPSKZ2HANCNFSM4HIPF3AQ .

abesto commented 5 years ago

Hm, that generalizes to "try to (add or) remove $PROJECT- to/from $MODULE". Sounds reasonable. It's still trial-and-error, which I'd like to avoid if possible. Let's not make a decision just yet, let's see what we learn from future migrations. I might also start looking at "reviewing" releases of other projects to gauge how much variability there is in the wild.