search

openzipkin-attic / apache-release-verification

Apache License 2.0
3 stars 1 forks source link

Add more allowed differences between repo and source archive #18

Closed abesto closed 5 years ago

abesto commented 5 years ago

In repo only: .gitattributes, .travis.yml

In source archive only: DEPENDENCIES

These were surfaced by Zipkin Layout Factory 0.0.5 currently up for vote.

codefromthecrypt commented 5 years ago

I also think CONTRIBUTING doesnt make sense in the zip as almost all content is about the policy of adding new files to a repo whereas the notices in the distribution are about consumption of files in a zip.

On Fri, Apr 26, 2019, 1:33 AM Zoltán Nagy notifications@github.com wrote:

@abesto https://github.com/abesto requested your review on: #18 https://github.com/openzipkin-contrib/apache-release-verification/pull/18 Add more allowed differences between repo and source archive.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/openzipkin-contrib/apache-release-verification/pull/18#event-2300966656, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAPVVZU5WENNOMMHKLFPBTPSHTP3ANCNFSM4HIPGSUQ .

abesto commented 5 years ago

we can discuss later about the CONTRIBUTING file

I think CONTRIBUTING mostly makes sense in the repo, as it describes how to submit change requests. It might be useful in the source archive if it points the reader to the repo ("I have this .jar, where do I send my PR?"), but then again that's a Google search away usually. Bottom line: I'm fine with either allowing it or not, long as we comply with ASF rules (unsure what's applicable here).

codefromthecrypt commented 5 years ago

my 2p. apache doesn't define this file, so it is up to us to decide.

note: in zipkin, this is under the .github directory, so a bit more obvious to exclude

On Fri, Apr 26, 2019 at 5:18 PM Zoltán Nagy notifications@github.com wrote:

we can discuss later about the CONTRIBUTING file

I think CONTRIBUTING mostly makes sense in the repo, as it describes how to submit change requests. It might be useful in the source archive if it points the reader to the repo ("I have this .jar, where do I send my PR?"), but then again that's a Google search away usually. Bottom line: I'm fine with either allowing it or not, long as we comply with ASF rules (unsure what's applicable here).

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/openzipkin-contrib/apache-release-verification/pull/18#issuecomment-486971164, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAPVV2V2LBPXTRF5PJ5E3LPSK3G7ANCNFSM4HIPGSUQ .

abesto commented 5 years ago

For anyone following along: #20 tracks doing this in a flexible per-repo way.