search

openzipkin-attic / apache-release-verification

Apache License 2.0
3 stars 1 forks source link

Update checks from latest dist layout changes #2

Closed devinsba closed 5 years ago

abesto commented 5 years ago

Hmm, by the way... wouldn't we also want to verify that mvnw is not in the source distribution before we download it? Might be simplest to do as a separate test. (Happy to implement it, takes all of two minutes, just looking for confirmation I understand correctly. Also happy to see it added to this PR.)

abesto commented 5 years ago

On second thought: the whole way we handle the repo-vs-source-archive verification is not great right now: we have specific things we expect to differ in either direction. I'll give making that more accurate a shot.

devinsba commented 5 years ago

Agreed, we need more of a blacklist + ignored list approach

abesto commented 5 years ago

@devinsba Check out #3 ;)

devinsba commented 5 years ago

Yeah, this particular integration test suite uses test containers, for some reason it fails from the zip, but is fine when I run from a git checkout, not sure what that's about.

I'm good with this change when you are @abesto

abesto commented 5 years ago

Squashed, merged. <3 Thank you!