search

openzipkin-attic / apache-release-verification

Apache License 2.0
3 stars 1 forks source link

Re-enable `mvn package` test #21

Closed abesto closed 5 years ago

abesto commented 5 years ago

Just noticed this is hasn't been running for some reason. Raising a PR in case this is desired behavior. We'll likely want to make the build command configurable in the near future.

codefromthecrypt commented 5 years ago

ps if this is conditional on pom.xml should be pretty safe for most repos

On Mon, Apr 29, 2019, 4:04 PM Zoltán Nagy notifications@github.com wrote:

Just noticed this is hasn't been running for some reason. Raising a PR in case this is desired behavior. We'll likely want to make the build command configurable in the near future.

You can view, comment on, or merge this pull request online at:

https://github.com/openzipkin-contrib/apache-release-verification/pull/21 Commit Summary

  • Re-enable mvn package test

File Changes

Patch Links:

- https://github.com/openzipkin-contrib/apache-release-verification/pull/21.patch

https://github.com/openzipkin-contrib/apache-release-verification/pull/21.diff

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/openzipkin-contrib/apache-release-verification/pull/21, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAPVVYOLE2I4ZVGNGMMGTTPS2TYDANCNFSM4HJBECDA .

abesto commented 5 years ago

Yeah I was thinking of adding some heuristics like that, and optionally overriding via an argument.

Don't have access to GitHub until tonight (my messup, never mind the details), feel free to push merge.

On Mon, Apr 29, 2019 at 11:23 AM Adrian Cole notifications@github.com wrote:

ps if this is conditional on pom.xml should be pretty safe for most repos

On Mon, Apr 29, 2019, 4:04 PM Zoltán Nagy notifications@github.com wrote:

Just noticed this is hasn't been running for some reason. Raising a PR in case this is desired behavior. We'll likely want to make the build command configurable in the near future.

You can view, comment on, or merge this pull request online at:

https://github.com/openzipkin-contrib/apache-release-verification/pull/21 Commit Summary

  • Re-enable mvn package test

File Changes

(1)

Patch Links:

-

https://github.com/openzipkin-contrib/apache-release-verification/pull/21.patch

https://github.com/openzipkin-contrib/apache-release-verification/pull/21.diff

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub < https://github.com/openzipkin-contrib/apache-release-verification/pull/21 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAAPVVYOLE2I4ZVGNGMMGTTPS2TYDANCNFSM4HJBECDA

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openzipkin-contrib/apache-release-verification/pull/21#issuecomment-487528815, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAOUTXTG64VQNKAERII3HTPS3EBRANCNFSM4HJBECDA .

-- Zoltán Nagy https://abesto.net