openzipkin-attic / apache-release-verification

Apache License 2.0
3 stars 1 forks source link

Fix #25: Introduce multiple levels of failures #27

Closed abesto closed 5 years ago

abesto commented 5 years ago

Highlights:

2019-04-30-233809_983x717

codefromthecrypt commented 5 years ago

probably it would help my brain a lot to classify what are actually ASF requirements from what are not. There's no requirement to have the files in the source dist match the repo. The first couple repos we've done matched so mentally we are anchored to this concept. Since we are testing things that are not requirements and not necessarily even valid. It would be cool to order the ones that are concrete at the top, then a line or something, then the extra checks we made up which may help, but are not actually requirements at the bottom.

abesto commented 5 years ago

I like the idea of separating ASF-required and non-ASF-required checks, filing a task. I have concerns around "There's no requirement to have the files in the source dist match the repo", let's have that discussion on #20.