search

openzipkin-attic / apache-release-verification

Apache License 2.0
3 stars 1 forks source link

LICENSE can have addendums #37

Closed codefromthecrypt closed 5 years ago

codefromthecrypt commented 5 years ago

We were required to make addendums to the LICENSE file, which trips the verification tool like this. One possible way out is to look that the file starts with the stock LICENSE text as opposed to exactly equals.

[FAIL] LICENSE is Apache 2.0
Executing `diff /tmp/tmppa_5v1dw/expected_license /tmp/tmppa_5v1dw/unzipped/zipkin-2.14.0/LICENSE` exited with non-zero status code 1. See above for output. (Note that the command was run under `set -euo pipefail`)
codefromthecrypt commented 5 years ago

here's an example of such https://github.com/apache/incubator-zipkin-dependencies/pull/138

abesto commented 5 years ago

Yeah this check is pretty fragile, and can be made infinitely complex :D I'll put up a PR to fix this case, pragmatic approach here I think is extending it just enough to support cases we care about on a case-by-case basis.