search

openzipkin-attic / apache-release-verification

Apache License 2.0
3 stars 1 forks source link

JDK 1.8 is somewhat niche #42

Open codefromthecrypt opened 5 years ago

codefromthecrypt commented 5 years ago

zipkin-dependencies requires JDK 1.8 at the moment due to some spark integration tests. However, iirc all other projects can work with JDK 11, and brave requires it. There's a maven-enforcer-plugin which craps out with a message concerning the JDK in use vs what's required.

This part will fail if there's a JDK mismatch

Executing build-and-test for maven
>> Executing `mvn --quiet -N io.takari:maven:wrapper -Dmaven=3.6.0` in '/tmp/tmpa0w0xarb/unzipped/brave-5.6.4'
shakuzen commented 5 years ago

Thanks for making the issue explicitly about this. If we can come up with a generic solution for #40 I think it will solve this, but perhaps there's a shorter-term solution we can put in place to unblock this for Zipkin projects for now.