search

openzipkin-attic / apache-release-verification

Apache License 2.0
3 stars 1 forks source link

Added proper(er) Makefile, pre-commit hook with linting. #9

Closed abesto closed 5 years ago

abesto commented 5 years ago

Also, README tweaks.

Fixes #8

abesto commented 5 years ago

Summoning @drolando for Makefile wisdom. No urgency, feel free to take your time, any thoughts are appreciated.

abesto commented 5 years ago

Turns out (and I knew this at some point but forgot) pip-tools does exactly what we need here. It maintains a lockfile for dependencies, so version drift is not a problem. It exposes a command pip-sync that makes sure the virtualenv it's in has exactly and only the dependencies defined. This means we have a guarantee that environments won't drift, while also saving the time-cost of rebuilding virtualenvs whenever something changes. It also-also provides an extra command to upgrade dependencies.

codefromthecrypt commented 5 years ago

whoot! thanks pywizards