Allow configuring ZIPKIN_BASE_URL for zipkin-ui image

openzipkin-attic / docker-zipkin

Docker images for OpenZipkin

Apache License 2.0

688 stars 329 forks source link

Allow configuring ZIPKIN_BASE_URL for zipkin-ui image #138

Closed codefromthecrypt closed 7 years ago

codefromthecrypt commented 7 years ago

This changes the zipkin-ui image to rewrite nginx configuration on start based on the ZIPKIN_BASE_URL variable, which defaults to 'http://zipkin:9411'. Users can change this variable to point at a different zipkin host such as a kubernetes pod.

See https://github.com/openzipkin/zipkin-ui/pull/38 Fixes #134

codefromthecrypt commented 7 years ago

tested locally and well.. finally works!