openzipkin-attic / docker-zipkin

Docker images for OpenZipkin
Apache License 2.0
687 stars 329 forks source link

Adds MODULE_OPTS to avoid clobbering 3rd party profile config #202

Closed codefromthecrypt closed 5 years ago

codefromthecrypt commented 5 years ago

When we switched to JRE 11, we also switched to distroless. There is a regression where if you set JAVA_OPTS, it undoes any profile setup for 3rd party modules like zipkin-aws. This could be perceived as messages from SQS not being processed because sqs wasn't loaded.

Instead, this creates a separate env MODULE_OPTS to hold the layered config. I tested this on zipkin-aws.