search

openzipkin-attic / docker-zipkin

Docker images for OpenZipkin
Apache License 2.0
687 stars 329 forks source link

Symlink busybox into bin. #207

Closed anuraaga closed 5 years ago

anuraaga commented 5 years ago

While zipkin has no scripts that directly reference /bin/sh, some users with their own Dockerfile might want to add them. While we could put the onus of symlinking these to the users as they should be using a Dockerfile for their customization, it's small enough that it seems reasonable to do it in our image.

Fixes #206

codefromthecrypt commented 5 years ago

works for me... tommy can yank the heart out if he disagrees :D

shakuzen commented 5 years ago

Looks reasonable to me

brempusz commented 5 years ago

Thanks for the fix. https://hub.docker.com/r/openzipkin/zipkin states it was updated 5 days ago. When do you plan to build/push image with this change?

BTW: there is #!/bin/sh in zipkin/run.sh so adding scripts to /bin is a good move :). It worked because ENTRYPOINT ["/busybox/sh", "run.sh"]

codefromthecrypt commented 5 years ago

@brempusz I will recut the last release now.