openzipkin-attic / docker-zipkin

Docker images for OpenZipkin
Apache License 2.0
688 stars 329 forks source link

Migrate to quay.io #38

Closed abesto closed 9 years ago

abesto commented 9 years ago

Why

Docker Hub supports dependent builds but doesn't support automatic docker tags from git tags. Quay.io supports automatic docker tags, but not dependent builds. We use the former to simulate the latter by starting zipkin-base with tags like base-1.4.0, and building FROM that tag in the other images; the images to be used by our users will still be versioned normally, with tags like 1.4.0.

Example

By pushing base-1.4.0 I started this zipkin-base build, creating the docker tag base-1.4.0 on zipkin-base. Then I updated the Dockerfiles and pushed the tag 1.4.0-quay.io (if we choose to migrate, we'd of course drop the qualifier). This started builds for the rest of the services, creating the docker tag 1.4.0-quay.io, like here.

codefromthecrypt commented 9 years ago

LGTM thanks for streamlining things. We'll need to warn users about the repo change until we have a process down to push "major" versions to dockerhub.

abesto commented 9 years ago

Closing this, will open another PR where the process is automated.