Closed codefromthecrypt closed 9 years ago
This work was almost all @abesto. The last mile was far easier with advice from @michaelsembwever
This is so exciting :)
Couple of nits inline. The only big one: we need to check in the compiled .class
file to make this work on quay.io
Also, could you split up your work and mine into two commits? Just to make it clear who committed what sinswork.
hehe the compiled file is checked in :) agree we need that as the whole point is to have this work with JRE. Addressing notes now.
great point about comments.. done
Ah, sorry, guess I missed the tiny line for the binary file in the diff view.
:sparkles: Looks good! :shipit:
ps to those wanting to get rid of the UnsatisfiedLinkError in the log. here's the cassandra upgrade https://github.com/openzipkin/docker-zipkin/pull/48
Also.. This allows docker-compose to work on EC2's default of a t1.micro! IOTW zipkin for 1c/hr cc @spencergibb
$ docker-machine -D create \
--driver amazonec2 \
--amazonec2-access-key $AWS_ACCESS_KEY_ID \
--amazonec2-secret-key $AWS_SECRET_ACCESS_KEY \
--amazonec2-vpc-id $AWS_VPC_ID \
--amazonec2-region us-west-2 \
--amazonec2-zone b \
test-instance1
# update security group to open port 9410,9411,8080
$ eval "$(docker-machine env test-instance1)"
$ cd docker-zipkin
$ docker-machine up -d
:+1:
Interestingly, I tried the java docker image with a spring-cloud/boot app and had to use delitescere/jdk:8
for some reason. /cc @dsyer @mstine
This change reduces the size of
zipkin-base
from 466.2 MB to 94.2 MB. This is achieved by switching fromdebian:sid
to a minimal base image built on Alpine Linux; a Java Docker image doesn't get much smaller than this. Here's what changes./bin/bash
is/bin/sh
java.beans
packages not in the JREPulled up
docker-compose up
with these images built locally, ranzipkin-tracegen
against them, and saw traces on the web interface.Sizes before