search

openzipkin-attic / docker-zipkin

Docker images for OpenZipkin
Apache License 2.0
688 stars 329 forks source link

Use overrides for docker-compose mysql setup #91

Closed klingerf closed 8 years ago

klingerf commented 8 years ago

The docker-compose-mysql.yml file appears to be incomplete, as it is not running the collector container. This branch switches that configuration to be an extention of the default docker-compose.yml file, using docker-compose overrides, described here:

https://docs.docker.com/compose/extends/#multiple-compose-files

In addition, I've fixed an issue where the zipkin-cassandra container would not exit if the storage type was not configured correctly. And I've modified the zipkin-web container to allow overriding the query service address without requiring linking.

codefromthecrypt commented 8 years ago

I like this, except promoting scribe, as we really want that to die.

klingerf commented 8 years ago

@adriancole Thanks for the feedback. I that case would it make sense to just remove the collector container entirely from both docker-compose.yml and docker-compose-mysql.yml? As it is now, it feels a bit incongruous for the collector to show up in one place but not the other.

Other thoughts -- maybe we should just remove docker-compose-mysql.yml, in favor of better documentation on running each of the provided containers? Am happy to put together some documentation in a separate branch if we want to go that route.

codefromthecrypt commented 8 years ago

I think mysql should be advertised as it was added because more people know that vs cassandra. I don't object to removing collector from both places. These files are supposed to be a quick start anyway, vs an actual recommended topology.

klingerf commented 8 years ago

Ok, great, have updated this branch to remove the collector container from the docker-compose files. And am cross-posting my comment from the openzipkin gitter transcript.

i’d like to:

  1. ship #91
  2. convert the 2 docker-compose files to v2, described here: https://docs.docker.com/compose/compose-file/#version-2
  3. add a docker-compose-legacy.yml file, that demonstrates the old linking approach plus running the collector container -- basically what docker-compose.yml looks like in master today

note after step 1 we’ll need to publish new docker images, since it will be much easier to remove linking once we have a new image that includes this change: https://github.com/openzipkin/docker-zipkin/pull/91/files#diff-3cf38cad5817677135b052c2d9c36ce0R7

codefromthecrypt commented 8 years ago

nice work