search

openzipkin-attic / sleuth-webmvc-example

See how much time Spring Boot services spend on an http request.
Apache License 2.0
175 stars 107 forks source link

the compatibility problem about dubbo tracing filter #20

Closed maoling closed 5 years ago

maoling commented 5 years ago

I test the dubbo tracing instrument and it's ok because it uses the denpendency is

<dependency>
      <groupId>com.alibaba.spring.boot</groupId>
      <artifactId>dubbo-spring-boot-starter</artifactId>
      <version>2.0.0</version>
</dependency>

but this dubbo version has not been maintained,and now offical version is 

<dependency>
      <groupId>com.alibaba.boot</groupId>
      <artifactId>dubbo-spring-boot-starter</artifactId>
      <version>0.2.0</version>
</dependency>

when use this one,the brave may not adapt to it and can not trace the PRC call chain which I have tested. Appendix: https://mvnrepository.com/artifact/com.alibaba.boot/dubbo-spring-boot-starter/0.2.0 https://mvnrepository.com/artifact/com.alibaba.spring.boot/dubbo-spring-boot-starter/2.0.0 https://github.com/alibaba/dubbo-spring-boot-starter https://github.com/apache/incubator-dubbo-spring-boot-project https://github.com/apache/incubator-dubbo-spring-boot-project https://github.com/alibaba/dubbo-spring-boot-starter

codefromthecrypt commented 5 years ago

yeah the official was not complete when we wrote this example. if you can help fix that would be great

maoling commented 5 years ago

ping @beiwei30 @mercyblitz

maoling commented 5 years ago

I guess this issue caused from the version of dubbo at first,but upgrade to the lasted 2.6.5,this rpc call chain cannot be traced by

com.alibaba.boot dubbo-spring-boot-starter 0.2.0

@adriancole Do you have any insight?

codefromthecrypt commented 5 years ago

@maoling thanks for the context. I am preparing for a meetup tomorrow and we have a workshop on the new UI tomorrow and friday. I will try not to forget to look into this saturday. if I do, please ping ok?

maoling commented 5 years ago

sir,take it easy!you are the model worker of zipkin(grin) ----- 原始邮件 ----- 发件人：Adrian Cole notifications@github.com 收件人：openzipkin/sleuth-webmvc-example sleuth-webmvc-example@noreply.github.com 抄送人：毛蛤丝 maoling199210191@sina.com, Mention mention@noreply.github.com 主题：Re: [openzipkin/sleuth-webmvc-example] the compatibility problem about dubbo tracing filter (#20) 日期：2018年12月05日 19点53分

@maoling thanks for the context. I am preparing for a meetup tomorrow and we have a workshop on the new UI today and tomorrow. I will try not to forget to look into this saturday. if I do, please ping ok?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

codefromthecrypt commented 5 years ago

@maoling PS tell me if you like this interview https://mp.weixin.qq.com/s/5RSMfBT0vU8CWdc7Dx9jPg

maoling commented 5 years ago

@adriancole good reference.awesome!

codefromthecrypt commented 5 years ago

ok I just verified the existing demo still works even if it is not the 0.2.0 variant. I will look at that now

codefromthecrypt commented 5 years ago

I look and the latest unpublished starter doesn't have much different https://github.com/apache/incubator-dubbo-spring-boot-project/compare/0.2.0

looking at 0.2.0 now

codefromthecrypt commented 5 years ago

ok try again. I fixed the branch and raised a couple issues on the new plugin. Nothing is critical