openzipkin-contrib / brave-opentracing

Bridge between OpenTracing and Brave
http://opentracing.io
Apache License 2.0
64 stars 39 forks source link

Extracts null on empty #103

Closed codefromthecrypt closed 4 years ago

codefromthecrypt commented 4 years ago

I noticed this https://github.com/opentracing-contrib/java-jms/pull/38 from @hanson76 and then thought probably we can just return null on extract when there was nothing.

Side note about https://github.com/opentracing-contrib/java-jms/pull/38

However, the change above is a bit off as it ignores baggage. Iotw, lack of traceId/spanId doesn't mean nothing was extracted, it just means a trace context wasn't extracted. Ignoring extractions due to lack of trace and span ID will drop baggage. In any case extracting only a trace ID is valid in AWS.