search

openzipkin-contrib / brave-ratpack

Brave instrumentation for Ratpack
Apache License 2.0
5 stars 4 forks source link

Support Ratpack 1.6 #8

Open hyleung opened 5 years ago

hyleung commented 5 years ago

Migrated from https://github.com/hyleung/ratpack-zipkin/issues/64

Ratpack 1.6 is out and should include a client interceptor API now. I suspect we will get better milage from using the interceptors and hope that it may also fix some anomalies around client tracing that have been seen under heavy load.

hyleung commented 5 years ago

@llinder I haven't create an issue for https://github.com/hyleung/ratpack-zipkin/issues/44 yet cos I'm not sure whether it should be part of the upgrade to Ratpack 1.6 or whether it makes more sense to just the 1.6 upgrade and then rework the http client tracing or try to split the two things.