search

openzipkin-contrib / play-zipkin-tracing

Provides distributed tracing for Play Framework and Akka using Zipkin.
Apache License 2.0
48 stars 19 forks source link

configurable protocol #17

Closed thinker0 closed 7 years ago

thinker0 commented 7 years ago

configurable protocol

takezoe commented 7 years ago

@thinker0 Thanks for your pull request! I'm thinking configuring complete url of the Zipkin server might be better as:

trace.zipkin.server-url = "https://localhost:9411"

How do you think about this idea?

codefromthecrypt commented 7 years ago

I think many libraries use baseUrl for this

On 3 Jun 2017 21:41, "Naoki Takezoe" notifications@github.com wrote:

@thinker0 Thanks for your pull request! I'm thinking configuring complete url of the Zipkin server might be better as:

trace.zipkin.server-url = "https://localhost:9411"

How do you think about this idea?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

codefromthecrypt commented 7 years ago

another way is to say zipkin.endpoint as this allows you to configure the path which can change when people proxy it https://github.com/openzipkin/zipkin-reporter-java/blob/master/okhttp3/src/main/java/zipkin/reporter/okhttp3/OkHttpSender.java#L73

takezoe commented 7 years ago

@adriancole Thanks, I chosebase-url in #20.

takezoe commented 7 years ago

@thinker0 Since this pull request is covered by #20 I close. If you have any opinion, please add comment there.

thinker0 commented 7 years ago

LGTM!