search

openzipkin-contrib / play-zipkin-tracing

Provides distributed tracing for Play Framework and Akka using Zipkin.
Apache License 2.0
48 stars 19 forks source link

Add base-url config key instead of separate host and port #20

Closed takezoe closed 7 years ago

takezoe commented 7 years ago

Before:

 trace {
   service-name = "zipkin-api-sample"
   zipkin {
     host = "localhost"
     port = 9411
     sample-rate = 0.1
   }
 }

After:

 trace {
   service-name = "zipkin-api-sample"
   zipkin {
     base-url = "http://localhost:9411"
     sample-rate = 0.1
   }
 }

This pull request covers #17.

takezoe commented 7 years ago

@adriancole Thanks for very quick reaction :-)