openzipkin-contrib / play-zipkin-tracing

Provides distributed tracing for Play Framework and Akka using Zipkin.
Apache License 2.0
48 stars 19 forks source link

Scribe Support #28

Closed knightpop closed 6 years ago

knightpop commented 6 years ago

Do you have any plan to support scribe?

because Scribe is faster than normal HTTP

see: https://github.com/twitter/finagle/tree/develop/finagle-zipkin#data-sink

And also easy to integrate with Finagle-Zipin

codefromthecrypt commented 6 years ago

scribe is a deprecated transport, and an archived project by facebook (archived years ago)

finagle retains scribe only for historical reasons. the current transports are here https://github.com/openzipkin/zipkin-finagle

codefromthecrypt commented 6 years ago

PS if you are looking for transports that can easily work with play tracing, there are ones here as well amazon and microsoft specific ones https://github.com/openzipkin/zipkin-reporter-java

knightpop commented 6 years ago

Hmm... ok, I didn't notice that issue scribe is deprecated transport... thanks for the reply. Our team usually do Zipkin with Finatra. Thanks for replying me again!

takezoe commented 6 years ago

@adriancole Thanks for your quick support!