openzipkin-contrib / play-zipkin-tracing

Provides distributed tracing for Play Framework and Akka using Zipkin.
Apache License 2.0
48 stars 19 forks source link

WIP configurable tracing #31

Closed codefromthecrypt closed 6 years ago

codefromthecrypt commented 6 years ago

This creates a tracing module from parts, and ensures lifecycle methods are invoked. This is part of getting to where we can inject HttpTracing.

The test needs to be fixed as I don't know best way to configure the dispatcher. It seems some sharing can be done between play and akka, possibly.

Help wanted on moving this farther.. once refactored I can help with getting HttpTracing stitched together.

takezoe commented 6 years ago

@adriancole Thanks. I will try to fix test after release new version because I haven't released for a long time.

codefromthecrypt commented 6 years ago

thanks, looks like they pass now. appreciate the help